Add rule to find missing intrinsic specifiers in use statements
#253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiamPattinson
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Amazing, many thanks for the contribution! ❤️
Overall this is looking great, but a few small changes will be needed before we can merge:
- The fix doesn't work in cases where a
::separator isn't present, such asuse iso_fortran_env. As a::is optional for a plainusestatement but necessary after addingintrinsic, we need to add it if it's missing. I've added a suggestion below that I think fixes the issue, and we'll need to add a plainusestatement to the tests too. - The fix has the potential to break a user's code if they're deliberately using their own module named
iso_fortran_env(or one of the other intrinsic modules) for whatever reason, so unfortunately it'll have to be listed as an unsafe fix. - We're following Ruff's rule naming convention, so I think a better name for it would be
MissingIntrinsic, as that would mean users could ignore this rule by adding the comment! allow(missing-intrinsic). With that said, I'm only just now realising that the ruleUseAllin the same file would be better namedMissingOnly, but as that would be a breaking change I'll leave it for another PR.
* Mark rule as unsafe * Handle case of use without :: * Rename rule to follow naming conventions
imciner2
force-pushed
the
im/missingintrinsic
branch
from
5dadbd9 to
8e51cb9
Compare
LiamPattinson
requested changes
Jan 7, 2025
LiamPattinson
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
All looks good to me! Thanks again for the contribution, I really appreciate it. @ZedThree I'm happy to merge this if you are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a linting rule that checks
usestatements for if they refer to an intrinsic module defined in the standard, and if so that theusestatement includes theintrinsicmodifier (or alternately, thenon_intrinsicmodifier if someone really wants to override a compiler intrinsic module). Including it is good practice since the compiler will prioritize modules outside the compiler first, so this makes the need for the compiler version explicit.